Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct https for monitoring.prow.istio.io #2610

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Correct https for monitoring.prow.istio.io #2610

merged 1 commit into from
Apr 23, 2020

Conversation

clarketm
Copy link
Member

@clarketm clarketm commented Apr 23, 2020 •
edited
Loading

Fix cert issue (and set default backend) for Prow monitoring: https://monitoring.prow.istio.io/

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 23, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2020
@clarketm clarketm mentioned this pull request Apr 23, 2020
Open
@cjwagner
Copy link
Member

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Apr 23, 2020
@clarketm clarketm removed the do-not-merge/hold Block automatic merging of a PR. label Apr 23, 2020
@istio-testing istio-testing merged commit c0ffdf6 into istio:master Apr 23, 2020
@clarketm clarketm deleted the monitoring-cert branch April 23, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner cjwagner approved these changes

@chases2 chases2 Awaiting requested review from chases2

@fejta fejta Awaiting requested review from fejta

@Katharine Katharine Awaiting requested review from Katharine

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@fejta fejta

@cjwagner cjwagner

@scottilee scottilee

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clarketm @cjwagner @fejta @googlebot @scottilee @istio-testing